Does the BahnCard 50 promotion also apply if the outward journey is in April but the return journey is not until May 2025?

No, the promotion is only valid for travel in April 2025 and the return journey must also be made by 30 April 2025 at the latest.